Mustache dev logging #919

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
@ekryski
Contributor

ekryski commented Apr 29, 2014

Added some better dev logging for mustache templates. I'm not sure of some of the intricacies of how it resolves when deeply nested, so I'm not sure if I'm missing any cases here but this should close #720 and #726.

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Apr 30, 2014

Contributor

Thanks! For this to close those issues, we will need similar warnings in can.stache. If you are interested, the similar place this happens in stache is here: https://github.com/bitovi/canjs/blob/minor/view/stache/mustache_core.js#L215

Contributor

justinbmeyer commented Apr 30, 2014

Thanks! For this to close those issues, we will need similar warnings in can.stache. If you are interested, the similar place this happens in stache is here: https://github.com/bitovi/canjs/blob/minor/view/stache/mustache_core.js#L215

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Apr 30, 2014

Contributor

I think "in mustache template" in:

Variable "' + key + '" not found in mustache template.'

is imprecise. Perhaps "Unable to find key value \""+key+"\"." to parallel the other warning.

Contributor

justinbmeyer commented Apr 30, 2014

I think "in mustache template" in:

Variable "' + key + '" not found in mustache template.'

is imprecise. Perhaps "Unable to find key value \""+key+"\"." to parallel the other warning.

@justinbmeyer justinbmeyer added this to the 2.1.0 milestone Apr 30, 2014

@ekryski

This comment has been minimized.

Show comment
Hide comment
@ekryski

ekryski Apr 30, 2014

Contributor

Yep you are right. I'll update that.

Contributor

ekryski commented Apr 30, 2014

Yep you are right. I'll update that.

@ekryski ekryski referenced this pull request Apr 30, 2014

Merged

Mustache dev logging #927

@ekryski

This comment has been minimized.

Show comment
Hide comment
@ekryski

ekryski Apr 30, 2014

Contributor

Closing this as it should be going to master. New PR is #927.

Contributor

ekryski commented Apr 30, 2014

Closing this as it should be going to master. New PR is #927.

@ekryski ekryski closed this Apr 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment