Upgrade to CanJS 3.0, Steal 0.16 #273
Conversation
|
Do not merge yet, there is a configuration problem. |
|
Configuration problem is now fixed. |
site/default/static/map.js
Outdated
| @@ -0,0 +1,34 @@ | |||
| module.exports = { | |||
There was a problem hiding this comment.
This could possibly break in the future if, for example, can-compute adds a new file to their project. I think what we should do here is create this module on the fly. Crawl through the can- packages and create this same configuration.
There was a problem hiding this comment.
What are the criteria for files to include? Just every script file that's not a test and not in node_modules?
There was a problem hiding this comment.
I think every .js file is fine from within node_modules/can-* is fine. You can exclude _test files if you want, but I don't think it will hurt anything to have "too much" configuration.
This implements what Matthew suggested here: https://github.com/bitovi/documentjs/pull/273/files#r115520424
chasenlehara
force-pushed
the
canjs-to-3.0
branch
from
e8b4cdc
to
7ccac1a
Compare
I think this will work correctly on Windows. 🤞
|
Changes look good! Thanks @chasenlehara |
chasenlehara
force-pushed
the
canjs-to-3.0
branch
3 times, most recently
from
dc28748
to
2f68731
Compare
chasenlehara
force-pushed
the
canjs-to-3.0
branch
from
2f68731
to
ff64527
Compare
Fixes #250