Expose Middleware #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
init package.json
Conflicts: .gitignore README.md package.json
| "name": "Gordon Hall", | ||
| "email": "gordon@bitpay.com" | ||
| } | ||
| ], | ||
| "scripts": { | ||
| "make-dist": "sh scripts/make-dist.sh", | ||
| "test": "node_modules/.bin/mocha test/* --reporter spec", | ||
| "test": "mocha test/* --reporter spec", |
There was a problem hiding this comment.
why are we assuming that devs will have mocha installed globally? it's set as a devDependency in the package.json, so it should be available locally.
There was a problem hiding this comment.
Great question; I wasn't able to get it running out of the .bin folder, but I knew I had it available globally. Seems like an environment-specific mechanism (unless I'm misunderstanding?), so is there a way to detect where mocha is available?
There was a problem hiding this comment.
not sure, always seems to be available to me at that path, but could be specific to my NPM version. assuming global might be just fine - users can install mocha globally, or likely already have it.
bitjson
pushed a commit
that referenced
this pull request
Feb 13, 2018
fix verify + change to phantomjs browser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes the Express middleware on the module.
Use:
app.use( bitauth.middleware );