This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
Fix a bug in Mnemonic._entropyChecksum #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The result of toString on a number can be different across browsers for large numbers. In particular, it's possible for IE to use exponential notation, which was breaking Mnemonic._entropyChecksum.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result of toString on a number can be different across browsers for large numbers. In particular, it's possible for IE to use exponential notation, which was breaking Mnemonic._entropyChecksum.
This can be reproduced using this seed:
patrol wise idea oyster inquiry crash dignity chronic scatter time admit pet, which is valid on Chrome and Firefox, but invalid on IE11 and Edge.