Conversation
9440d47
to
dfe7052
Compare
8b40b4f
to
6a00c8c
Compare
62ee824
to
87ba5be
Compare
Note: this PR requires #39 which is why it is failing. |
These vectors I believe originally came from: https://github.com/trezor/python-mnemonic/blob/master/vectors.json It may be useful to follow up upstream as well? |
Yes, I created these using python by replacing existing code with Japanese (rather than adding supprt for multiple languages). Then I ran those tests manually against my own javascript implementation based off early versions of bip39 (bitcoinjs-lib), but again, no upstream support. I just added Japanese in a pr to bip39 the other day. I should also add the vectors to python-mnemonic. |
How did you produce the seed hex values? Did you run |
I believe I just used the same as English. |
I was running #39 with vectors generated from |
@braydonf thats because the generate_vectors uses passphrase TREZOR whereas mine use a japanese passphrase |
I tried using that one as well, and didn't have any luck. |
@braydonf I just tried again, and suddenly forgot how to get python to cooperate with UTF-8... I struggled for a while, and decided to quit. However, the vectors I have here I have verified against the python reference implementation... though I forget how I did it. I even tried using a VM with Ubuntu, still was getting ASCII errors crying about \u3000... |
I used python3, and the |
(Note: changed this PR to only contain JP test vectors)
This will add Japanese test vectors to the library.