Get block hashes by timestamp range #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Get Block Hashes by Timestamp range | ||
|
|
||
| var time1 = 1441911000; // Notice time is in seconds not milliseconds |
There was a problem hiding this comment.
missing backticks for code formatting
pnagurny
force-pushed
the
feature/timestamp-blocks
branch
from
8c6b991
to
1f2cfea
Compare
|
LGTM: tests pass locally |
|
If we can store the indexes as binary, e.g. sending a buffer for the key and value, and receiving a buffer the data storage size will be half the size, and faster to write and read. |
pnagurny
force-pushed
the
feature/timestamp-blocks
branch
from
1f2cfea
to
3c128bb
Compare
|
Updated to binary encode leveldb key and value. |
pnagurny
force-pushed
the
feature/timestamp-blocks
branch
from
3c128bb
to
78a65cc
Compare
pnagurny
force-pushed
the
feature/timestamp-blocks
branch
from
78a65cc
to
00d3a0b
Compare
|
LGTM |
|
Testing with bitpay/insight-api#368 |
|
LGTM |
braydonf
pushed a commit
that referenced
this pull request
Sep 16, 2015
Get block hashes by timestamp range
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #204