Fix bug in Request.getPayload()

Apparently, node v0.12 buffer.writeUInt8 is more lenient than v0.10
bitpay · Dec 15, 2015 · 0ea205d · 0ea205d
1 parent 6a88aaa
commit 0ea205d
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/lib/messages/commands/reject.js b/lib/messages/commands/reject.js
@@ -57,7 +57,7 @@ RejectMessage.prototype.getPayload = function() {
   var bw = new BufferWriter();
   bw.writeVarintNum(this.message.length);
   bw.write(new Buffer(this.message, 'utf-8'));
-  bw.writeUInt8(this.cccode);
+  bw.writeUInt8(this.ccode);
   bw.writeVarintNum(this.reason.length);
   bw.write(new Buffer(this.reason, 'utf-8'));
   bw.write(this.data);

diff --git a/test/messages/commands/index.js b/test/messages/commands/index.js
@@ -284,6 +284,26 @@ describe('Command Messages', function() {
       expect(message.reason).to.be.undefined;
       expect(message.data).to.be.undefined;
     });
+    it('should write payload correctly', function() {
+      var message = messages.Reject({
+        message: 'tx',
+        ccode: 0x01,
+        reason: 'transaction is malformed',
+        data: new Buffer('12345678901234567890123456789012', 'hex')
+      });
+      var payload = message.getPayload();
+      message = messages.Reject();
+      message.setPayload(payload);
+      message.message.should.equal('tx');
+      message.ccode.should.equal(0x01);
+      message.reason.should.equal('transaction is malformed');
+      message.data.toString('hex').should.equal('12345678901234567890123456789012');
+      //var message = messages.Reject();
+      //expect(message.message).to.be.undefined;
+      //expect(message.ccode).to.be.undefined;
+      //expect(message.reason).to.be.undefined;
+      //expect(message.data).to.be.undefined;
+    });
   });
 
   describe('Version', function() {