Added configuration option to only connect to trusted peers. Closes #26 #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braydonf
force-pushed
the
feature/configuration-options
branch
from
5682d77
to
a93b733
Compare
braydonf
force-pushed
the
feature/configuration-options
branch
from
a93b733
to
ae97e36
Compare
braydonf
changed the title
| } | ||
| } | ||
| ] | ||
| }); |
There was a problem hiding this comment.
Could you add comments to each option to make it clearer, please? (we want docs to be as obvious as possible)
Example:
var pool = new Pool(Networks.livenet, {
discover: false, // prevent Pool from discovering and connecting to new peers
listenAddr: false, // handle network addr messages
addrs: [ // initial peers to connect to
{
ip: {
v4: '127.0.0.1'
}
}
]
});
btw: why do we have both discover and listenAddr? can we simplify that into 1 config setting?
|
great work! I made some small comments above |
…documentation for the options.
|
Updated |
maraoz
added a commit
that referenced
this pull request
Feb 18, 2015
Added configuration option to only connect to trusted peers. Closes #26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.