Add 'peerconnect' event from Pool #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
throughnothing
force-pushed
the
peerconnect-event
branch
from
f1117b7
to
762beaf
Compare
|
The connect event should likely have a separate test, as the "new addrs" test is only testing for handling of "addr" messages. |
throughnothing
force-pushed
the
peerconnect-event
branch
from
762beaf
to
e92cc5e
Compare
|
@braydonf yup, was already working on a better test, that will test |
throughnothing
force-pushed
the
peerconnect-event
branch
2 times, most recently
from
8b4a57f
to
3ed6931
Compare
| @@ -100,4 +100,40 @@ describe('Pool', function() { | |||
|
|
|||
| }); | |||
|
|
|||
| it('should propagate connect, ready, and disconnect peer evenst', function(done) { | |||
There was a problem hiding this comment.
There is a typo and and extra space.
|
Interesting, I thought there may have been a test for disconnect, but it doesn't look like it. It should test to make sure that the peer has been removed from |
throughnothing
force-pushed
the
peerconnect-event
branch
from
3ed6931
to
269487e
Compare
|
Good catch, updated. |
throughnothing
force-pushed
the
peerconnect-event
branch
from
269487e
to
e0b58e2
Compare
|
LGTM |
|
great contribution, thanks @throughnothing ! |
maraoz
added a commit
that referenced
this pull request
Feb 18, 2015
Add 'peerconnect' event from Pool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be useful to some consumers. I'm using it to detect nodes that are connected, but slow to respond with their
verackcommands, to disconnect these slow nodes and get different nodes in my pool.