This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
Fix/format amount #293
Merged
Fix/format amount #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
isocolsky
commented
Jun 23, 2016
isocolsky
commented
- Provide short representation & full precision representation.
- Truncate exceeding decimals (instead of rounding).
| @@ -161,8 +165,10 @@ Utils.formatAmount = function(satoshis, unit, opts) { | |||
| opts = opts || {}; | |||
|
|
|||
| var u = Constants.UNITS[unit]; | |||
| var amount = (satoshis / u.toSatoshis).toFixed(u.maxDecimals); | |||
| return addSeparators(amount, opts.thousandsSeparator || ',', opts.decimalSeparator || '.', u.minDecimals); | |||
| var precision = opts.fullPrecision ? 'full' : 'short'; | |||
There was a problem hiding this comment.
Always help to have opts :)
There was a problem hiding this comment.
Always help to have opts :)
sparklecoin
pushed a commit
to sparklecoin/bitcore-wallet-client
that referenced
this pull request
Nov 13, 2017
Fix/format amount
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.