This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
fix verification of payProUrl equals null #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greggzigler
changed the title
| toAddress: toAddress, | ||
| }] | ||
| }; | ||
| function doit(opts, doNotVerifyPayPro, doBroadcast, done) { | ||
| helpers.createAndJoinWallet(clients, 1, 1, function(w) { |
There was a problem hiding this comment.
Could you please move creation of the wallet & address outside of this function so it only gets called once at the start of the test?
greggzigler
changed the title
| @@ -903,7 +903,7 @@ API.prototype.sendTxProposal = function(opts, cb) { | |||
| feePerKb: opts.feePerKb, | |||
| payProUrl: opts.payProUrl, | |||
| type: opts.type, | |||
| outputs: opts.outputs, | |||
| outputs: _.cloneDeep(opts.outputs), | |||
There was a problem hiding this comment.
because at line 910, the message is overwritten with the encrypted message. without cloning, the sendTxProposal() function will modify the client's copy of opts.
…th-payprourl Conflicts: test/client.js
matiu
added a commit
that referenced
this pull request
Aug 14, 2015
fix verification of payProUrl equals null
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now verifier.js (line 104) matches api.js (line 836) regarding payProUrl in signature