Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

Adds replaceTemporaryRequestKey #162

Merged
merged 7 commits into from
Apr 2, 2015
Merged

Adds replaceTemporaryRequestKey #162

merged 7 commits into from
Apr 2, 2015

Conversation

matiu
Copy link
Collaborator

@matiu matiu commented Apr 1, 2015

  • for copay migration

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 95.8% when pulling 4a82df4 on matiu:feat/replaceTmpReqKey into fe01b8e on bitpay:master.

@@ -46,6 +47,8 @@ Copayer.fromObj = function(obj) {
x.xPubKey = obj.xPubKey;
x.requestPubKey = obj.requestPubKey;
x.signature = obj.signature;
x.isTemporaryRequestKey = obj.isTemporaryRequestKey || false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the fromObj method should return the object exactly as stored in the db.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 95.8% when pulling 1f0b329 on matiu:feat/replaceTmpReqKey into fe01b8e on bitpay:master.

@matiu
Copy link
Collaborator Author

matiu commented Apr 1, 2015

updated.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 95.8% when pulling 4357a56 on matiu:feat/replaceTmpReqKey into fe01b8e on bitpay:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.19%) to 95.8% when pulling 4357a56 on matiu:feat/replaceTmpReqKey into fe01b8e on bitpay:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.19%) to 95.81% when pulling 7ec58b2 on matiu:feat/replaceTmpReqKey into fe01b8e on bitpay:master.

@matiu matiu changed the title WIP: adds replaceTemporaryRequestKey Adds replaceTemporaryRequestKey Apr 2, 2015
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.16%) to 95.33% when pulling ae2ec61 on matiu:feat/replaceTmpReqKey into d7964a8 on bitpay:master.

isocolsky added a commit that referenced this pull request Apr 2, 2015
@isocolsky isocolsky merged commit d11887f into bitpay:master Apr 2, 2015
chainfailure pushed a commit to chainfailure/viacore-wallet-service that referenced this pull request Feb 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants