Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

Feat/2 step opt #718

Merged
merged 9 commits into from Nov 2, 2017
Merged

Feat/2 step opt #718

merged 9 commits into from Nov 2, 2017

Conversation

matiu
Copy link
Collaborator

@matiu matiu commented Oct 31, 2017

Optimizes 2-step balance:

1- prevent counting addresses if wallet was already determined big enough
2- prevent the "second step" if it was performed in less that 1hr ago and it had no result
3- adds tests to 'address activation' by BCmonitor
4- better fetching/query for 'active' addresses

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 83.348% when pulling 002f9c7 on feat/2-step-opt into 7a12b17 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 83.168% when pulling 2d46dca on feat/2-step-opt into 7a12b17 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 83.168% when pulling 2d46dca on feat/2-step-opt into 7a12b17 on master.

Copy link
Member

@cmgustavo cmgustavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Test OK (Create, Re-create, Import, Send, Receive)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 83.175% when pulling 0b6e577 on feat/2-step-opt into 7a12b17 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 83.186% when pulling b8c52a8 on feat/2-step-opt into 7a12b17 on master.

@bitpay bitpay deleted a comment from 270815 Nov 2, 2017
@cmgustavo
Copy link
Member

Ack

@matiu matiu merged commit cc9e0ba into master Nov 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants