Merge pull request #441 from ryanxcharles/bug/sin-encodeddata

SIN should call VersionedData constructor
bitpay · Jul 18, 2014 · 7866f5c · 7866f5c
2 parents 3bed2e0 + 4523012
commit 7866f5c
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 7 deletions.
diff --git a/lib/SIN.js b/lib/SIN.js
@@ -6,8 +6,10 @@ function SIN(type, payload) {
   if (typeof type != 'number') {
     SIN.super_.call(this, type, payload);
     return;
-  };
+  }
   this.data = new Buffer(1 + 1 + payload.length);
+  this.converters = this.encodings['binary'].converters;
+  this._encoding = this.encodings['binary']._encoding;
   this.encoding('binary');
   this.prefix(0x0F); // SIN magic number, in numberspace
   this.type(type);

diff --git a/test/test.SIN.js b/test/test.SIN.js
@@ -33,6 +33,14 @@ describe('SIN', function() {
       s.should.equal(a.toString()); // check that validation doesn't change data
     });
   });
+
+  describe('#SIN', function() {
+    it('should be able to create a new SIN with a version byte', function() {
+      var myhash = bitcore.util.sha256ripe160('test');
+      var sin = new SIN(SIN.SIN_EPHEM, myhash);
+      should.exist(sin);
+    });
+  });
 });
 
 

diff --git a/test/test.SINKey.js b/test/test.SINKey.js
@@ -4,16 +4,11 @@ var chai = chai || require('chai');
 var bitcore = bitcore || require('../bitcore');
 var should = chai.should();
 
-var SINKeyModule = bitcore.SINKey;
-var SINKey;
+var SINKey = bitcore.SINKey;
 
 
 describe('SINKey', function() {
   it('should initialze the main object', function() {
-    should.exist(SINKeyModule);
-  });
-  it('should be able to create class', function() {
-    SINKey = SINKeyModule;
     should.exist(SINKey);
   });
   it('should be able to create instance', function() {
@@ -24,4 +19,13 @@ describe('SINKey', function() {
     should.exist(sk.privKey.public);
     should.exist(sk.privKey.compressed);
   });
+
+  describe('#storeObj', function() {
+    it('should give an object', function() {
+      var sinkey = new SINKey();
+      sinkey.generate();
+      var obj = sinkey.storeObj();
+      should.exist(obj);
+    });
+  });
 });