Skip to content

Commit

Permalink
complete base58_keys_valid tests
Browse files Browse the repository at this point in the history
  • Loading branch information
maraoz committed Mar 19, 2014
1 parent 4b430be commit f0b9cd0
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Key.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ if (process.versions) {
throw new Error('Arg should be a buffer');
}
var type = p[0];
this.compressed = type!==4;
this.compressed = type!==0x04;
this._pub = p;
},
get: function(){
Expand Down
11 changes: 8 additions & 3 deletions test/test.misc.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ var base58Check = base58.base58Check;

var Address = bitcore.Address;
var networks = bitcore.networks;
var WalletKey = bitcore.WalletKey;

describe('Miscelaneous stuff', function() {
it('should initialze the config object', function() {
Expand Down Expand Up @@ -71,15 +72,19 @@ describe('Miscelaneous stuff', function() {
var hexPayload = datum[1];
var meta = datum[2];
it('base58 keys valid ' + b58, function() {
var network = meta.isTestnet?networks.testnet:networks.livenet;
if (meta.isPrivkey) {
(true).should.equal(true);
var k = new WalletKey({network: network});
k.fromObj({priv: b58});
k.privKey.compressed.should.equal(meta.isCompressed);
buffertools.toHex(k.privKey.private).should.equal(hexPayload);
new Address(b58).isValid().should.equal(false);
} else {
var a = new Address(b58);
a.isValid().should.equal(true);
a.isScript().should.equal(meta.addrType === 'script');
a.network().should.equal(meta.isTestnet?networks.testnet:networks.livenet);
a.network().should.equal(network);
}

});
});

Expand Down

0 comments on commit f0b9cd0

Please sign in to comment.