Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong parameter name at documentation #1036

Closed
matiu opened this issue Feb 5, 2015 · 0 comments · Fixed by #1037
Closed

Wrong parameter name at documentation #1036

matiu opened this issue Feb 5, 2015 · 0 comments · Fixed by #1037

Comments

@matiu
Copy link
Contributor

matiu commented Feb 5, 2015

In Transaction#applySignature documentation SignHash is named signhash
https://github.com/bitpay/bitcore/blob/master/lib/transaction/transaction.js#L667

but in Input is called as signtype
https://github.com/bitpay/bitcore/blob/master/lib/transaction/input/input.js#L145

Which leads the checkParamenter to fail.
matiu added a commit that referenced this issue Feb 5, 2015
@matiu
Update transaction.js
5fa3846 
Fixes #1036
@matiu matiu mentioned this issue Feb 5, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update transaction.js bitpay/bitcore
1 participant
@matiu