-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import bufferput into bitcore #75
Comments
I think part of the problem is because the bufferput module in the npm registry hasn't been updated with the fix from this commit bitpay/node-bufferput@6b2ad51 (i.e. the bufferput module from npm install bitcoin or from npm install in a cloned bitcore repo doesn't contain the fixed version) |
What do you think of updating the dependency to point to https://github.com/bitpay/node-bufferput instead of the npm package? Like we did with "browserify-bignum": "git://github.com/maraoz/browserify-bignum.git" |
@maraoz That is an OK solution, too. It is tiny and not widely used outside of bitcore, so reducing the number of dependencies by incorporating into bitcore seemed easy, efficient, and likely to permanently solve the reported problems. |
Sorry, I'm not that familiar with participating in open source projects yet. (I was confused by who the "you" in "What do you think ..." was referring to.) Should I make changes and submit a pull request?? Any changes made with the node-bufferput dependency should be applied to the insight repo too though. |
Bug/fix unconfigmed tx
We constanty have issues with bufferput. Would be easier to deal with if we just imported it into bitcore.
The text was updated successfully, but these errors were encountered: