Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BufferPut NPM Out of Date #98

Closed
dyoder opened this issue Feb 27, 2014 · 10 comments
Closed

BufferPut NPM Out of Date #98

dyoder opened this issue Feb 27, 2014 · 10 comments

Comments

@dyoder
Copy link

dyoder commented Feb 27, 2014

If I run:

npm install bitcore

the NPM for bufferput contains what appears to be older code. Specifically, the error where some of the methods are defined on Buffer is still there.

The symptom is that you get an word32le is undefined message.

I was able to resolve this by using npm link against local copies of the bitcore and bufferput repos.

@maraoz
Copy link
Contributor

maraoz commented Feb 27, 2014

I'll look into it. Thanks for reporting

@maraoz
Copy link
Contributor

maraoz commented Feb 27, 2014

I just created a test project which requires bitcore from npm and the Address example from README runs smoothly. I've heard from @ryanxcharles that others were having problems with BufferPut too. Can you tell us what OS and example you were running?

@SomeoneWeird
Copy link
Contributor

@maraoz This is exactly why I said the npm module needs updating, there was a breaking bug fixed in master that made all the examples not work (bar the address one)

@maraoz
Copy link
Contributor

maraoz commented Feb 27, 2014

I see. We're trying to get more people to have publish permissions to bitcore's npm so we accelerate this whole process. Thanks for your help!

@ryanxcharles
Copy link
Contributor

We just updated bitcore on npm, but if I read correctly, it is bufferput that is problematic. Correct? We'll need @gasteve to update npm for that.

@ryanxcharles
Copy link
Contributor

We have some version conflicts with bufferput. The version on BitPay GitHub is 0.1.1, but has code committed more recently than the 0.1.2 that is on npm. I suppose I could merge one into the other, update the version number, and then see if @gasteve can put that one on npm.

@ryanxcharles
Copy link
Contributor

Actually there are no differences in the index.js between the npm and bitpay github versions of bufferput, so there can't be any fixes in one that aren't in the other. If someone can figure out if there are any issues with the bitpay github bufferput, and issue a pull request that fixes it, then we can get the npm updated.

@SomeoneWeird
Copy link
Contributor

784e4e3

@ryanxcharles
Copy link
Contributor

So, there's no problem then. FWIW I just tested the block monitoring example by installing bitcore fresh from npm and did not have any bufferput issues.

@SomeoneWeird
Copy link
Contributor

Ah, I missed the bit where you said 'we just updated bitcore on npm' - my bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants