-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BufferPut NPM Out of Date #98
Comments
I'll look into it. Thanks for reporting |
I just created a test project which |
@maraoz This is exactly why I said the npm module needs updating, there was a breaking bug fixed in master that made all the examples not work (bar the address one) |
I see. We're trying to get more people to have publish permissions to bitcore's npm so we accelerate this whole process. Thanks for your help! |
We just updated bitcore on npm, but if I read correctly, it is bufferput that is problematic. Correct? We'll need @gasteve to update npm for that. |
We have some version conflicts with bufferput. The version on BitPay GitHub is 0.1.1, but has code committed more recently than the 0.1.2 that is on npm. I suppose I could merge one into the other, update the version number, and then see if @gasteve can put that one on npm. |
Actually there are no differences in the index.js between the npm and bitpay github versions of bufferput, so there can't be any fixes in one that aren't in the other. If someone can figure out if there are any issues with the bitpay github bufferput, and issue a pull request that fixes it, then we can get the npm updated. |
So, there's no problem then. FWIW I just tested the block monitoring example by installing bitcore fresh from npm and did not have any bufferput issues. |
Ah, I missed the bit where you said 'we just updated bitcore on npm' - my bad. |
fix addr broadcast and sync info;
If I run:
the NPM for
bufferput
contains what appears to be older code. Specifically, the error where some of the methods are defined onBuffer
is still there.The symptom is that you get an
word32le is undefined
message.I was able to resolve this by using
npm link
against local copies of thebitcore
andbufferput
repos.The text was updated successfully, but these errors were encountered: