Require on use #129
Merged
Require on use #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 10, 2014 16:47
Normally when one loads the bitcore object, all classes are loaded into memory, even if they are not used. This comment updates this so that the classes are only required when they are actually used, preserving memory and making bitcore as small and light for each project. This code is only relevant for node, since the browser will have the ability to compile only the selected components. Also, the Key class does not yet work with this, but everything else does.
Now, like all other modules loaded in the bitcore object, Key is only required when it is actually used. All tests pass in node and the browser.
|
ACK: Tests OK in node, The example: The examples at examples/ for node are OK. |
|
Fixed the address example. |
|
Excellent changes. We should add tests that run the examples so that this On Mon, Mar 10, 2014 at 6:52 PM, Ryan X. Charles
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In node, in order to keep the memory overhead of bitcore low, we only want to require modules that are actually used. So to do this we replace the getters of all the bitcore.X classes with a function that only requires the class when it is accessed. That way the classes are not loaded if they are not used, and the memory overhead is kept low.
A similar feature is planned for the browser where we will compile only the modules that are directed to the browser bundle.