Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove versionGuard error if versions are same. #1303

Closed
wants to merge 1 commit into from

Conversation

olalonde
Copy link
Contributor

I'm not sure why there is this version guard in the first place. It's extremely annoying and non idiomatic. What's the big deal if there is more than one bitcore in memory?

@braydonf
Copy link
Contributor

There is still an issue with running multiple instances of Bitcore with the same version. instanceof handling will fail, and the networks object is a singleton and thus adding and getting networks will behave unexpectedly.

If Bitcore plugins are used, including bitcore in the main package.json dependencies will alleviate issues as would be expected when using peerDependencies and npm@3.

@olalonde
Copy link
Contributor Author

olalonde commented Aug 6, 2015

Ok guess we can close this though I'm not really sure that's how peerDependencies work. The most annoying thing is that it breaks npm link. I still think this should just be a warning but not a process.exit().

@olalonde olalonde closed this Aug 6, 2015
@kaibakker
Copy link

I got the same issue and I am not that experienced with npm.
I added

"peerDependencies": {
    "bitcore": "^0.12.15"
  },

but when running npm update it gives The package bitcore does not satisfy its siblings' peerDependencies requirements!. npm outdated says 0.12.15 is the only version of bitcore I use.

A little more explanation would be great for those who are less experienced with npm.

@braydonf
Copy link
Contributor

Please see: #1328 there are more details there. It's likely that bitcore needs to be required at the top-level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants