Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minify and optimize bundle #144

Merged
merged 2 commits into from
Mar 12, 2014
Merged

Conversation

maraoz
Copy link
Contributor

@maraoz maraoz commented Mar 12, 2014

This improves the size of browser bundles, especially the ones build with only cherry-picked submodules

For the original version, 1.521s to create, 564K size
For the uglified version, 4.399s to create, 260K size
For the uglified version with only util/log module 3.143s, 160K size
For the uglified version with only util/log module, after optimization 1.695s, 64K size

For the uglified version with only Address module and dependencies, after optimization 1.834s, 68K size

@maraoz maraoz mentioned this pull request Mar 12, 2014
@ryanxcharles
Copy link
Contributor

Awesome. Reviewing.

@ryanxcharles
Copy link
Contributor

ACK. Confirmed to make big difference in file size, and all node/browser tests pass. We will need a server-side app to run this code and generate customizable versions of bitcore than you can run from bitcore.io just like for twitter bootstrap or jQuery.

ryanxcharles pushed a commit that referenced this pull request Mar 12, 2014
@ryanxcharles ryanxcharles merged commit 461836c into bitpay:master Mar 12, 2014
@maraoz maraoz deleted the feature/minify-bundle branch March 13, 2015 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants