adding few tests for Peer.js #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reviewing. Seems like this tests need you to run bitcoind, which is not good. Let me check though |
|
Nope, they work in node and the browser. My bad. Thanks for your contribution @manan19!!! 👍 |
|
@maraoz Out of curiosity, how did you run the browser tests? I've only been running the mocha tests. |
|
@manan19 you need to update the browser bundle ( |
slowfx
pushed a commit
to slowfx/bitcore-mona
that referenced
this pull request
Jul 14, 2015
Change awkward wording "On sync" to "Synchronised"
micahriggan
pushed a commit
to micahriggan/bitcore
that referenced
this pull request
Dec 27, 2018
Ref/notifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.