add BIP70 protobuf features in new PayPro lib file #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 2, 2014 11:39
...and add to the "main" bundle, but not the "all" bundle, since it adds hundreds of kilobytes to the bundle.
|
Great work! PayPro sounds cool 👍 |
ryanxcharles
pushed a commit
that referenced
this pull request
Jul 3, 2014
add BIP70 protobuf features in new PayPro lib file
micahriggan
pushed a commit
to micahriggan/bitcore
that referenced
this pull request
Dec 27, 2018
add BIP70 protobuf features in new PayPro lib file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BIP70 uses protobufs to for the message format. This PR adds support for all the standard BIP70 message formats using a library called protobuf.js (protobufjs on npm) which works in both node and the browser, with optimizations for node (buffers rather than arraybuffers). Since protobufjs adds hundreds of kilobytes to the bundle, it is includede in "all", but not "main". You have to build "all" to get this.
No BIP70 in the browser:
node browser/build.js --includemainBIP70 in the browser:
node browser/build.js --includeall