DER format signatures #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 17, 2014 13:09
both creating DER signature from the r and s values, and parsing a DER signature into the r, s, and other properties.
"sign" and "genk" ... and add some signature tests
To make it easier to test the master branch of bitcore with other apps, especially Copay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Great Crypto Update, I accidentally wronged the code that made signatures so that they weren't in proper DER format. This was causing signatures created by bitcore to be rejected by bitcoin-qt clients. I've fixed this by creating some new functions in common/Key that create and parse DER signatures in a very explicit and detailed way so that this particular problem doesn't arise again. I've also fixed a number of minor issues related to signatures and crypto, such as exposing the "sign" and "genk" functions in Key, and getting rid of the deprecated Curve class.
I found this thread helpful: https://bitcointalk.org/index.php?topic=653313.0
Closes #438