Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing tests for new methods added #467

Merged
merged 5 commits into from
Jul 30, 2014

Conversation

maraoz
Copy link
Contributor

@maraoz maraoz commented Jul 28, 2014

This adds tests that were pending since #451

fixes https://github.com/bitpay/copay/issues/949
fixes #460

}
};
return testF;
};
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high order functions FTW!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.42%) when pulling d0d5248 on maraoz:add/missing-tests into 434ba6f on bitpay:master.

@ryanxcharles
Copy link
Contributor

Closes #460

@maraoz
Copy link
Contributor Author

maraoz commented Jul 29, 2014

@ryanxcharles did you close this by mistake?

@maraoz
Copy link
Contributor Author

maraoz commented Jul 29, 2014

ping

@maraoz maraoz reopened this Jul 29, 2014
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.27%) when pulling d0d5248 on maraoz:add/missing-tests into 434ba6f on bitpay:master.

ryanxcharles pushed a commit that referenced this pull request Jul 30, 2014
Add missing tests for new methods added
@ryanxcharles ryanxcharles merged commit cd353ac into bitpay:master Jul 30, 2014
@ryanxcharles
Copy link
Contributor

Woops, does looks like I closed it by mistake. Merged now.

@maraoz maraoz deleted the add/missing-tests branch March 13, 2015 15:24
micahriggan pushed a commit to micahriggan/bitcore that referenced this pull request Dec 27, 2018
support TLS 1.2 in standalone BWS
micahriggan pushed a commit to micahriggan/bitcore that referenced this pull request Dec 27, 2018
Add missing tests for new methods added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for new untested functions add tests to bitcore PR
3 participants