-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation refactor #1005
Merged
JohnathanWhite
merged 2 commits into
bitpay:master
from
gabrielbazan7:ref/nested-navigation
Jan 4, 2024
Merged
Navigation refactor #1005
JohnathanWhite
merged 2 commits into
bitpay:master
from
gabrielbazan7:ref/nested-navigation
Jan 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielbazan7
force-pushed
the
ref/nested-navigation
branch
6 times, most recently
from
December 19, 2023 17:52
a74ccb8
to
9817d13
Compare
gabrielbazan7
force-pushed
the
ref/nested-navigation
branch
7 times, most recently
from
December 20, 2023 14:47
125791d
to
69dfce6
Compare
gabrielbazan7
force-pushed
the
ref/nested-navigation
branch
6 times, most recently
from
December 20, 2023 19:04
c7a055f
to
e01f090
Compare
Gamboster
previously approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I did many tests in iOS simulator. The improvement in performance is notable
gabrielbazan7
force-pushed
the
ref/nested-navigation
branch
from
December 20, 2023 20:28
e01f090
to
ac877a6
Compare
Gamboster
previously approved these changes
Dec 20, 2023
cmgustavo
previously approved these changes
Dec 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK! 👍🏼
gabrielbazan7
dismissed stale reviews from cmgustavo and Gamboster
via
December 29, 2023 18:15
ed01471
gabrielbazan7
force-pushed
the
ref/nested-navigation
branch
from
December 29, 2023 18:15
ac877a6
to
ed01471
Compare
gabrielbazan7
force-pushed
the
ref/nested-navigation
branch
from
December 29, 2023 18:18
ed01471
to
65a6991
Compare
Gamboster
previously approved these changes
Dec 29, 2023
cmgustavo
previously approved these changes
Dec 29, 2023
gabrielbazan7
dismissed stale reviews from cmgustavo and Gamboster
via
January 3, 2024 14:14
ce26ad3
gabrielbazan7
force-pushed
the
ref/nested-navigation
branch
3 times, most recently
from
January 3, 2024 14:51
a7ae9a1
to
dc2c7d7
Compare
Gamboster
previously approved these changes
Jan 3, 2024
gabrielbazan7
force-pushed
the
ref/nested-navigation
branch
from
January 3, 2024 18:10
dc2c7d7
to
6b5e6c5
Compare
gabrielbazan7
force-pushed
the
ref/nested-navigation
branch
from
January 3, 2024 19:32
6b5e6c5
to
f9eaa92
Compare
Gamboster
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.