Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation refactor #1005

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

gabrielbazan7
Copy link
Collaborator

No description provided.

@gabrielbazan7 gabrielbazan7 force-pushed the ref/nested-navigation branch 6 times, most recently from a74ccb8 to 9817d13 Compare December 19, 2023 17:52
@gabrielbazan7 gabrielbazan7 changed the title WIP Ref/nested navigation Navigation refactor Dec 19, 2023
@gabrielbazan7 gabrielbazan7 force-pushed the ref/nested-navigation branch 7 times, most recently from 125791d to 69dfce6 Compare December 20, 2023 14:47
@gabrielbazan7 gabrielbazan7 force-pushed the ref/nested-navigation branch 6 times, most recently from c7a055f to e01f090 Compare December 20, 2023 19:04
Gamboster
Gamboster previously approved these changes Dec 20, 2023
Copy link
Collaborator

@Gamboster Gamboster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I did many tests in iOS simulator. The improvement in performance is notable

Gamboster
Gamboster previously approved these changes Dec 20, 2023
cmgustavo
cmgustavo previously approved these changes Dec 26, 2023
Copy link
Member

@cmgustavo cmgustavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK! 👍🏼

Gamboster
Gamboster previously approved these changes Dec 29, 2023
cmgustavo
cmgustavo previously approved these changes Dec 29, 2023
@gabrielbazan7 gabrielbazan7 dismissed stale reviews from cmgustavo and Gamboster via ce26ad3 January 3, 2024 14:14
@gabrielbazan7 gabrielbazan7 force-pushed the ref/nested-navigation branch 3 times, most recently from a7ae9a1 to dc2c7d7 Compare January 3, 2024 14:51
Gamboster
Gamboster previously approved these changes Jan 3, 2024
@JohnathanWhite JohnathanWhite merged commit 092b1b5 into bitpay:master Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants