Confirm, Coinbase and Gift Card Screen Fixes #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
msalcala11
commented
Feb 6, 2024
•
msalcala11
commented
- Better handles common send errors in bill pay, gift card, and paypro confirm screens
- Fixes Coinbase 2fa screen (ensures all content is displayed inside a SafeAreaView)
- Falls back to displaying a claim link for a gift card that comes with a barcode when the barcode fails to generate
- Fixes offchain Coinbase payments with ERC20 tokens
- Improves reliability of gift card barcode scanning when using dark mode
…screens and fix coinbase 2fa screen and flow
msalcala11
force-pushed
the
handle-invalid-password
branch
from
15287bb
to
ceebdd9
Compare
msalcala11
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.