Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: prevent unlock modal from being displayed twice in a row when the app is open #1100

Merged

Conversation

Gamboster
Copy link
Collaborator

@Gamboster Gamboster commented Mar 22, 2024

Way to reproduce the issue: Leave the app open for more than 20 seconds, in which case the lockAuthorizedUntil will have expired. When closing and reopening the app, the value of lockAuthorizedUntil was not removed, so after successfully passing the unlock to open the app, it interprets that lockAuthorizedUntil has expired and asks for it again.

The solution I propose is to add lockAuthorizedUntil to the appReduxPersistBlackList

Copy link
Member

@cmgustavo cmgustavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK!

@JohnathanWhite JohnathanWhite merged commit 64fbf27 into bitpay:master Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants