-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable barebones Xwalk compatibility #96
Conversation
} | ||
|
||
vv.setBackgroundColor(Color.TRANSPARENT); | ||
vv.setAlpha(0.0f); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setBackgroundColor
here does nothing [for me]; but I left it in to show what would be ideal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nolanlawson any tips?
setAlpha
allows us to see the camera view, but it is not ideal as we only want BackgroundColor
transparency so we can interact with vv
.
vv = (View) getView.invoke(webView); | ||
} catch (Exception e) { | ||
e.printStackTrace(); | ||
return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error should probably go back through the callback...
ping @gildebrand @dPary |
8a43420 has been added purely for using this branch in a test deployment, it can be removed if this PR is progressed |
I'm not familiar with the cordova development. To be honest it stinks and sucks, I have removed this setBackground stuff. You don't need to tweak with setBackground stuff. It would be beneficial also, if there would be some standalone example which works in android studio. It's a partial solution, because i don't see any buttons on the screen. Just a full camera screen.
|
What shows:
What doesn't show:
This isn't ready to merge, as
setAlpha(0.0f)
completely destroys this packages original premise... but it is a start for maybe someone else to take over and or use as an "almost there" solution.For me, it gives enough headroom (combined with an informational "toast") to inform them they can "tap-to-exit", and allow me to promptly migrate away from Crosswalk...
The WebView HTML overlay is actually there, and can be interacted with... it just isn't showing.
I don't know why - @bitjson if you can see why, please fix 馃拑