Merge pull request #291 from p-maguire/SP-934

SP-934: Change satoshisPerByte to Double, update tests, and bump version
bitpay · May 9, 2024 · 0d65b60 · 0d65b60
2 parents 376671e + 6b7fb49
commit 0d65b60
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/src/main/java/com/bitpay/sdk/Config.java b/src/main/java/com/bitpay/sdk/Config.java
@@ -34,7 +34,7 @@ public class Config {
     /**
      * BitPay Plugin Info Version.
      */
-    public static final String BITPAY_PLUGIN_INFO = "BitPay_Java_Client_v10.0.1";
+    public static final String BITPAY_PLUGIN_INFO = "BitPay_Java_Client_v10.0.2";
     /**
      * BitPay Api Frame.
      */

diff --git a/src/main/java/com/bitpay/sdk/model/invoice/MinerFeesItem.java b/src/main/java/com/bitpay/sdk/model/invoice/MinerFeesItem.java
@@ -17,7 +17,7 @@
 @JsonIgnoreProperties(ignoreUnknown = true)
 public class MinerFeesItem {
 
-    protected Integer satoshisPerByte;
+    protected Double satoshisPerByte;
     protected Integer totalFee;
     protected Double fiatAmount;
 
@@ -33,7 +33,7 @@ public MinerFeesItem() {
      * @return the satoshis per byte
      */
     @JsonIgnore
-    public Integer getSatoshisPerByte() {
+    public Double getSatoshisPerByte() {
         return this.satoshisPerByte;
     }
 
@@ -43,7 +43,7 @@ public Integer getSatoshisPerByte() {
      * @param satoshisPerByte the satoshis per byte
      */
     @JsonProperty("satoshisPerByte")
-    public void setSatoshisPerByte(Integer satoshisPerByte) {
+    public void setSatoshisPerByte(Double satoshisPerByte) {
         this.satoshisPerByte = satoshisPerByte;
     }
 

diff --git a/src/test/java/com/bitpay/sdk/ConfigTest.java b/src/test/java/com/bitpay/sdk/ConfigTest.java
@@ -58,7 +58,7 @@ public void it_should_returns_bitpay_api_version() {
 
     @Test
     public void it_should_returns_bitpay_plugin_info() {
-        Assertions.assertTrue(Config.BITPAY_PLUGIN_INFO.contains("BitPay_Java_Client_v10.0.1"));
+        Assertions.assertTrue(Config.BITPAY_PLUGIN_INFO.contains("BitPay_Java_Client_v10.0.2"));
     }
 
     @Test

diff --git a/src/test/java/com/bitpay/sdk/model/invoice/MinerFeesItemTest.java b/src/test/java/com/bitpay/sdk/model/invoice/MinerFeesItemTest.java
@@ -13,7 +13,7 @@ public class MinerFeesItemTest {
     @Test
     public void it_should_manipulate_satoshisPerByte() {
         // given
-        Integer expected = 765;
+        Double expected = 765.1;
         MinerFeesItem testedClass = this.getTestedClass();
 
         // when