Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot verify the published app #10425

Open
Giszmo opened this issue Dec 14, 2019 · 8 comments
Open

Cannot verify the published app #10425

Giszmo opened this issue Dec 14, 2019 · 8 comments

Comments

@Giszmo
Copy link

Giszmo commented Dec 14, 2019

At the time of working on this article on the verifiability of your PlayStore app, I failed to verify it. I would much appreciate if you could provide better build instructions so that developers can verify the app easily.

@matiu
Copy link
Collaborator

matiu commented Dec 14, 2019 via email

@Giszmo
Copy link
Author

Giszmo commented Dec 16, 2019

Our findings are laid out in the article you read.

May I take your comment as confirmation that you do not verify builds? I don't care about bit-wise deterministic builds but about verifiability. If engineer A on his machine that might have a code-swapping virus compiles the app, can engineer B verify the build or not?

How high a bounty do you estimate to be for injecting such a virus on the release manager's machine? Would the release manager watch his family remain hostage before injecting malicious code? Those are the extreme fantasies that made me push for verifiability at Mycelium.

@AndreasGassmann
Copy link

Just FYI, we use the same stack (ionic + cordova) in our project AirGap. We use docker and our builds are deterministic, see the discussion here.

@matiu
Copy link
Collaborator

matiu commented Jan 6, 2020 via email

@Giszmo
Copy link
Author

Giszmo commented Mar 29, 2020

Three months later ... guys, your wallet has more than half a million downloads! It's negligence to not verify the release manager's build! He might have a backdoor on his machine or be put under duress to steal all the funds of all the users. How is the status of this issue?

@matiu
Copy link
Collaborator

matiu commented Mar 30, 2020

Hi @Giszmo,

we are on the process of implement a build process based on docker, similar to the one AirGap (thanks again @AndreasGassmann ) is using. We will update this ticket one it is on production.

Thanks for bringing this point to our attention.

@Giszmo
Copy link
Author

Giszmo commented Oct 1, 2020

It's been a while. How are things going? Time to try rebuilding again??

@emanuelb
Copy link

Currently building the latest version fails: #11748 (comment) thus instructions on how to build latest version in container is the first step, @matiu is there any progress regarding Docker build stack mentioned in #10425 (comment) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants