Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallets-tab): update balance for new wallets when receiving funds #11444

Merged

Conversation

cmgustavo
Copy link
Member

@cmgustavo cmgustavo commented Jan 15, 2021

Issues

  • If wallet has been created recently, balance 0. After received funds, I had to restart the app to see new balance in the list of wallets.
  • hasZeroBalance lock the value in zero, due to cached info is empty (for recently created wallet).

@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #11444 (a73c562) into master (87cf7d7) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11444      +/-   ##
==========================================
- Coverage   32.03%   32.02%   -0.01%     
==========================================
  Files         228      228              
  Lines       18872    18876       +4     
  Branches     2951     2951              
==========================================
  Hits         6045     6045              
- Misses      12329    12333       +4     
  Partials      498      498              
Impacted Files Coverage Δ
src/pages/tabs/tabs.ts 12.50% <0.00%> (-0.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87cf7d7...a73c562. Read the comment docs.

Copy link
Collaborator

@Gamboster Gamboster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gamboster Gamboster merged commit d33dc64 into bitpay:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants