Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: reenable tslint prefer-conditional-expression, fix #8084

Merged

Conversation

bitjson
Copy link
Contributor

@bitjson bitjson commented Feb 20, 2018

No description provided.

@codecov
Copy link

codecov bot commented Feb 20, 2018

Codecov Report

Merging #8084 into master will increase coverage by <.01%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8084      +/-   ##
==========================================
+ Coverage   27.27%   27.28%   +<.01%     
==========================================
  Files          23       23              
  Lines        2621     2613       -8     
  Branches      391      389       -2     
==========================================
- Hits          715      713       -2     
+ Misses       1883     1877       -6     
  Partials       23       23
Impacted Files Coverage Δ
src/providers/language/language.ts 58.82% <0%> (+3.26%) ⬆️
src/providers/bwc-error/bwc-error.ts 6.54% <0%> (+0.17%) ⬆️
src/providers/logger/logger.ts 63.15% <0%> (+1.08%) ⬆️
src/providers/persistence/persistence.ts 43.98% <100%> (-0.24%) ⬇️
src/providers/release/release.ts 96.96% <0%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 322451a...bcdfe73. Read the comment docs.

Copy link
Member

@cmgustavo cmgustavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@cmgustavo cmgustavo merged commit f2fa241 into bitpay:master Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants