Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Sphinx 1.7 #77

Closed
wants to merge 1 commit into from
Closed

Support Sphinx 1.7 #77

wants to merge 1 commit into from

Conversation

hroncok
Copy link
Contributor

@hroncok hroncok commented Jun 26, 2018

Fixes #73

@hroncok
Copy link
Contributor Author

hroncok commented Jun 26, 2018

BTW I've tested this locally with Python 3.70rc1. You might want to add it to the CI, but that's out of scope of this PR.

@bitprophet
Copy link
Owner

Awesome, thanks! I'll take this for a spin soon.

@bitprophet bitprophet added this to the 1.5 milestone Jun 26, 2018
@bitprophet
Copy link
Owner

  • My current default venvs are Python 3.6, fwiw...
  • checked out our 1.5 branch since this is largely a bugfix level change
  • triple checked that Sphinx 1.7.5 blows up when I run inv test
  • cherry-picked the commit from this PR
  • confirmed that inv test works fine now
  • merged up to 1.6 and master
  • retested
  • just pushed for Travis checkup

@hroncok
Copy link
Contributor Author

hroncok commented Jul 2, 2018

Merged in b425544

@hroncok hroncok closed this Jul 2, 2018
@hroncok hroncok deleted the sphinx17 branch July 2, 2018 18:48
@bitprophet
Copy link
Owner

Beat me to it! Was gonna wait til Travis was green :D so far, 1.6 has checked in so I'm not worried.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@hroncok @bitprophet