Skip to content
This repository has been archived by the owner on Mar 31, 2022. It is now read-only.

add firebase-tools (firebase cli) #256

Merged
merged 8 commits into from
Oct 7, 2019
Merged

add firebase-tools (firebase cli) #256

merged 8 commits into from
Oct 7, 2019

Conversation

Vrtak-CZ
Copy link
Contributor

@Vrtak-CZ Vrtak-CZ commented Sep 12, 2019

It's required for using Firebase App Distribution.
https://firebase.google.com/products/app-distribution

Pull Request Checklist

Check/accept these:

  • I've updated the version in the Dockerfile
  • I've updated the CHANGELOG.md
  • I've provided a link or explanation below which describes the changes in the tool itself

Dockerfile Outdated Show resolved Hide resolved
viktorbenei
viktorbenei previously approved these changes Sep 26, 2019
Copy link
Contributor

@viktorbenei viktorbenei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤖 👍

@viktorbenei
Copy link
Contributor

The usual concern with any preinstalled tool is whether they require the latest version of this tool to be available, cause if they do it’s usually not a good idea to preinstall the tool as that’ll only be updated once a week.

That said in this case we'll also have a Step for Firebase App Distribution which should be able to handle this case, when a newer version of the tool would be required and update the tool during the step's run.

@koral--
Copy link
Contributor

koral-- commented Sep 26, 2019

According to Firebase CLI docs there is no strong requirement on having the latest version. It's only a good practice.
https://firebase.google.com/docs/cli#update-cli

ghaabor
ghaabor previously approved these changes Oct 2, 2019
@ghaabor
Copy link
Contributor

ghaabor commented Oct 2, 2019

@Vrtak-CZ please update the CHANGELOG.md file with the added tool and the version number accordingly in the Dockerfile

@viktorbenei
Copy link
Contributor

I submitted our usual PR checklist to this repo #260

@Vrtak-CZ Vrtak-CZ dismissed stale reviews from ghaabor and viktorbenei via 51b15d6 October 7, 2019 09:39
@Vrtak-CZ
Copy link
Contributor Author

Vrtak-CZ commented Oct 7, 2019

@Vrtak-CZ please update the CHANGELOG.md file with the added tool and the version number accordingly in the Dockerfile

Done

Copy link
Contributor

@viktorbenei viktorbenei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you @Vrtak-CZ ! :)

@viktorbenei
Copy link
Contributor

Also thanks @koral-- for the infos ;)

@viktorbenei viktorbenei merged commit 4ff4ba9 into bitrise-io:master Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants