Add visionOS Simulator as platform #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tothszabi
reviewed
Nov 23, 2023
destination/parse.go
Outdated
|
|
||
| // simctl reports visionOS as xrOS | ||
| if runtime.Platform == "xrOS" && wantedPlatform == string(VisionOS) { |
There was a problem hiding this comment.
I think this will break in one of the next Xcode update. At the moment the Vision Pro OS is called xrOS but Apple is actively renaming it to visionOS. Once that is done this if statement will not work because runtime.Platform == "xrOS" will be never true.
The problem is that this will be silent breakage so I think we should already add the new expected OS name there too. Like
if (runtime.Platform == "xrOS" || runtime.Platform == "visionOS") && wantedPlatform == string(VisionOS) {
...
}
There was a problem hiding this comment.
That's a cool idea! Fixed
tothszabi
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for handling
visionOSdestinations, devices, platform lookups, etc.Tested in bitrise-steplib/bitrise-step-xcode-start-simulator#10