New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add visionOS platform support #10
Conversation
@@ -153,7 +153,7 @@ func (s SimulatorStarter) prepareSimulator(simulator destination.Device, waitFor | |||
} | |||
|
|||
UDID := simulator.ID | |||
if shouldReset || simulator.Arch != "" { | |||
if shouldReset { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed this with @lpusok, it was probably incorrect and caused by the poor E2E testing that didn't shut down simulators across the tests. Since the Rosetta E2E test came after the basic test case, it detected the first tests's simulator as a "matching" device (despite the arch difference) and needed a reset.
Checklist
step.yml
andREADME.md
is updated with the changes (if needed)Version
Requires a MINOR version update
Context
Changes
go-xcode
that adds visionOS platform support to destination handling.reset
input tono
as this is the default value and this makes the most sense in CI envs.Investigation details
Decisions