Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visionOS platform support #10

Merged
merged 12 commits into from Nov 27, 2023
Merged

Add visionOS platform support #10

merged 12 commits into from Nov 27, 2023

Conversation

ofalvai
Copy link
Contributor

@ofalvai ofalvai commented Nov 23, 2023

Checklist

  • I've read and followed the Contribution Guidelines
  • step.yml and README.md is updated with the changes (if needed)

Version

Requires a MINOR version update

Context

Changes

  • Pull latest go-xcode that adds visionOS platform support to destination handling.
  • Clean up and fix broken E2E tests. First, simulators were not shut down between tests, this is now fixed. Second, set the reset input to no as this is the default value and this makes the most sense in CI envs.
  • Add a workaround for visionOS boot completion as it's broken at the moment (Xcode 15.1 Beta 3). Even though the boot detection works locally, it crashes the entire simulator in CI. I tried adding artificial delays, didn't help. Since visionOS is still very unstable, I think it's better if we add the overall visionOS support to the step and just disable boot completion waiting temporarily.

Investigation details

Decisions

@@ -153,7 +153,7 @@ func (s SimulatorStarter) prepareSimulator(simulator destination.Device, waitFor
}

UDID := simulator.ID
if shouldReset || simulator.Arch != "" {
if shouldReset {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed this with @lpusok, it was probably incorrect and caused by the poor E2E testing that didn't shut down simulators across the tests. Since the Rosetta E2E test came after the basic test case, it detected the first tests's simulator as a "matching" device (despite the arch difference) and needed a reset.

@ofalvai ofalvai marked this pull request as ready for review November 24, 2023 08:55
@ofalvai ofalvai merged commit 4847ec2 into main Nov 27, 2023
1 check passed
@lpusok lpusok deleted the SSW-1100-visionos branch December 12, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants