Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle old way of variant listing too #47

Merged
merged 6 commits into from
Jul 18, 2022
Merged

Conversation

ofalvai
Copy link
Contributor

@ofalvai ofalvai commented Jul 18, 2022

Checklist

  • I've read and followed the Contribution Guidelines
  • step.yml and README.md is updated with the changes (if needed)

Version

Requires a PATCH version update

Context

Parsing multiple variants in the variant input was accidentally changed in #43. This PR adds support for parsing the old way of defining variants, we shouldn't have changed the existing behavior in a patch version.

Changes

Parse the variant list by splitting both by line breaks (the literal \n) and by the "\n" substring (this was the old behavior).

Investigation details

Defining a list of variants by line breaks works in both the workflow editor GUI and in raw YML, like this:

inputs:
  variant: |-
    fullDevelopDebug
    fullDevelopRelease
  module: app

Decisions

@ofalvai ofalvai merged commit 1f52f43 into master Jul 18, 2022
@ofalvai ofalvai deleted the fix-multiple-variants branch July 18, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants