Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various cleanups #15

Merged
merged 4 commits into from
Nov 8, 2022
Merged

Various cleanups #15

merged 4 commits into from
Nov 8, 2022

Conversation

ofalvai
Copy link
Contributor

@ofalvai ofalvai commented Nov 4, 2022 •
edited
Loading

Checklist

  • I've read and followed the Contribution Guidelines
  • step.yml and README.md is updated with the changes (if needed)

Version

Requires a PATCH version update

Context

Changes

  • Update go-steputils to the latest version: most importantly, it pulls the change around cache API token: Update cache API token handling bitrise-io/go-steputils#69
  • Handle the parameter changes of cache.NewRestorer()
  • Update token generation parameters in E2E tests
  • Make E2E test cache keys unique in order to isolate tests from other step tests

Investigation details

Decisions

@ofalvai ofalvai requested a review from vturda November 8, 2022 12:22
@ofalvai ofalvai marked this pull request as ready for review November 8, 2022 12:23
@ofalvai ofalvai merged commit a9006da into main Nov 8, 2022
@ofalvai ofalvai deleted the various-cleanups branch November 8, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vturda vturda vturda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ofalvai @vturda