Update bundletool version #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bundletool used is over 1.5 years old. Meanwhile many improvements have been applied to the tool to support latest android features and packaging.
|
Hi @carlonzo we appreciate your contribution to this step |
vshah23
approved these changes
May 23, 2023
vshah23
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
step.ymlandREADME.mdis updated with the changes (if needed)Version
Requires a MAJOR/MINOR/PATCH version update
Context
The bundletool used is over 1.5 years old. Meanwhile many improvements have been applied to the tool to support latest android features and packaging.
Changes
Updates the bundletool default version. Here a list of release notes: https://github.com/google/bundletool/releases
Decisions
We have experienced issues while the step was downloading that version of bundletool, failing the build. One step before we downloaded bundletool (latest) and the download was successful. I am aware that bumping version doesnt fix download issues but this is how I realized we were downloading a 1.5yo version.