Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra warning text if Step fails on an ARM (Apple Silicon/M1) machine #29

Conversation

hisaac
Copy link
Contributor

@hisaac hisaac commented Jul 15, 2022

Note: A matching PR to the avd-manager Step can be found here: bitrise-steplib/steps-avd-manager#41

Checklist

  • I've read and followed the Contribution Guidelines
  • step.yml and README.md is updated with the changes (if needed)

Version

Requires a PATCH version update

Context

Running this Step on Apple Silicon machines is not officially supported. This change adds some additional warning text to help make that clear to users if the step fails and they don't expect it.

Changes

  • Adds warning text to the step.yml and README.md.
  • Updates the go-utils version to v2.0.0-alpha.8 to get access to the new CPU functions.
  • Adds a check within the failf method to display the additional warning text if the Step fails on an ARM-based machine.

Screenshots

Failure on Intel machine:

wait-for-android-emulator-intel

Failure on Apple Silicon machine:

wait-for-android-emulator-arm

@hisaac
Copy link
Contributor Author

hisaac commented Jul 15, 2022

The CI keeps failing. It hangs when trying to run on macOS machines. I'm reverting to what's on master to see if that runs on CI or not.

@hisaac hisaac force-pushed the STEP-2015-update-the-avd-manager-and-the-wait-for-android-emulator-step-description-m-1-not-supported branch from 99b65d7 to f6e77ea Compare July 18, 2022 12:16
@hisaac hisaac closed this Jul 18, 2022
@hisaac hisaac reopened this Jul 18, 2022
@hisaac hisaac force-pushed the STEP-2015-update-the-avd-manager-and-the-wait-for-android-emulator-step-description-m-1-not-supported branch from a97f5e5 to d1f3b15 Compare July 18, 2022 13:24
@hisaac hisaac merged commit 5cd6329 into master Jul 18, 2022
@hisaac hisaac deleted the STEP-2015-update-the-avd-manager-and-the-wait-for-android-emulator-step-description-m-1-not-supported branch July 18, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants