Add code_signing_allowed config property #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shams-ahmed Still more work to do I'm sure, but wanted to get this up to make sure I'm headed in the right direction. |
shams-ahmed
reviewed
May 3, 2022
…urable-on-steps-xcode-build-for-simulator # Conflicts: # main.go
1 task
…urable-on-steps-xcode-build-for-simulator
shams-ahmed
previously approved these changes
May 13, 2022
shams-ahmed
approved these changes
May 13, 2022
hisaac
deleted the
STEP-1992-make-code-signing-allowed-configurable-on-steps-xcode-build-for-simulator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30
Checklist
step.ymlandREADME.mdis updated with the changes (if needed)Version
Requires a MINOR update
Context
Some builds need to allow codesigning when building for the simulator, but the step in its current state does not allow this to be configured easily.
Changes
codes_signing_allowedconfiguration optionSetDisableCodesignmethod