Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export BITRISE_XCRESULT_PATH also when test fails #112

Merged
merged 2 commits into from
Apr 15, 2019
Merged

Export BITRISE_XCRESULT_PATH also when test fails #112

merged 2 commits into from
Apr 15, 2019

Conversation

ollitapa
Copy link
Contributor

@ollitapa ollitapa commented Apr 9, 2019

I have a small issue related to #103. The xcresult would need to be also available when the tests fail, so we can parse and find the failing test.

BirmacherAkos
BirmacherAkos approved these changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@BirmacherAkos BirmacherAkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ollitapa !

Nice catch! Thanks for the fix 🥇

@BirmacherAkos BirmacherAkos merged commit 97d7bf3 into bitrise-steplib:master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trapacska trapacska trapacska approved these changes

@BirmacherAkos BirmacherAkos BirmacherAkos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ollitapa @trapacska @BirmacherAkos