Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix copy paste on macOS #121

Merged
merged 2 commits into from
Jul 16, 2019
Merged

fix copy paste on macOS #121

merged 2 commits into from
Jul 16, 2019

Conversation

twksos
Copy link
Contributor

@twksos twksos commented May 10, 2019

this patch fixes copy paste on macOS by add edit menu.

@clockworkgr
Copy link
Member

thanks, but this is handled (for win/linux at least) in https://github.com/bitshares/beet/blob/develop/src/lib/electron_context_menu.js

Could you check what adjustments need to be made there instead?

@twksos
Copy link
Contributor Author

twksos commented May 11, 2019

@clockworkgr

I don't think there is anything todo with context menu.
The modification is about the application menu on macOS, which related to the global edit shortcut(cut/copy/paste/select all).

The context menu is the menu you trigger with secondary click (right click).
The item accelerator (like CmdOrCtrl+C) on mac is the key you used to select menu item after menu shows up. Like right click on a file and do a rename by key M in windows.

@clockworkgr
Copy link
Member

I love have to check but the idea was that all electron apps suffer from this and adding the context menu fixes it.

If it also needs your patch, can you refactor to a separate file similar tow how context menu is handled?

@twksos
Copy link
Contributor Author

twksos commented May 11, 2019

@clockworkgr

  1. The function has been move to another folder.
  2. I think the solution for copy/paste has been application menu since 2015.
    And it should work on all platforms, at least in my past projects.
    Please check out this issue and this blog.
  3. I'm also interested in the source of solving it by context menu.

@sschiessl-bcp
Copy link
Collaborator

I love have to check but the idea was that all electron apps suffer from this and adding the context menu fixes it.

If it also needs your patch, can you refactor to a separate file similar tow how context menu is handled?

Since you looked into it, is that mergable?

@clockworkgr
Copy link
Member

I love have to check but the idea was that all electron apps suffer from this and adding the context menu fixes it.
If it also needs your patch, can you refactor to a separate file similar tow how context menu is handled?

Since you looked into it, is that mergable?

well..code location is fine and it looks good but have no mac to test it :)

@sschiessl-bcp sschiessl-bcp merged commit 91b31fa into bitshares:develop Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants