Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebased PR #213 #219

Merged
merged 6 commits into from
Nov 18, 2022
Merged

Rebased PR #213 #219

merged 6 commits into from
Nov 18, 2022

Conversation

grctest
Copy link
Contributor

@grctest grctest commented Nov 6, 2022

Add QR code support
Add TOTP code support
Improve menu UX
Improve prompt UX with accordion components
Fix wallet idle/timeout functionality


See original pull request: #213

Add QR code support
Add TOTP code support
Improve menu UX
Improve prompt UX with accordion components
Fix wallet idle/timeout functionality
@sschiessl-bcp
Copy link
Collaborator

image

Can you please fix the layout?

@sschiessl-bcp
Copy link
Collaborator

When I login and logout I see this error
image

@grctest
Copy link
Contributor Author

grctest commented Nov 15, 2022

Sorry about that, I'll check out these issues right away!

Dashboard contents were attempting render during logout
Remove 50px top margin on language dropdown button
@grctest
Copy link
Contributor Author

grctest commented Nov 15, 2022

Resolved the two issues you identified, thanks for pointing them out 👍

The logout error was strange, currently the router sends the client to "/", however the "/dashboard" route's dashboard component attempts to render during this transition; I included a v-if to prevent the components attempting to render out of sequence.

@sschiessl-bcp
Copy link
Collaborator

Clicking on TOTP or QR in menu gives this
image

rename settings store totp to chainPermissions
fix qr/totp not showing
fix several warnings on logout from certain routes
@grctest
Copy link
Contributor Author

grctest commented Nov 15, 2022

Committed fixes for the issues you reported, now browsing to the qr/totp with both production and testnet bitshares accounts works as expected

fixed

@sschiessl-bcp
Copy link
Collaborator

Thanks, checking agian

@sschiessl-bcp
Copy link
Collaborator

The language selector is unnecessary, user will have selected proper language already. Can you also make it fit into the popup size without scrolling?
image

This was done with parsing a QR

Prompt language selector moved to new settings accordion segment
Swapped language selector button type
UX improvements in transactionrequestpopup
@grctest
Copy link
Contributor Author

grctest commented Nov 17, 2022

The prompt language selector has been moved to a new accordion segment
I've refined the specified popup so it's more compact:

newux

@sschiessl-bcp
Copy link
Collaborator

The prompt language selector has been moved to a new accordion segment I've refined the specified popup so it's more compact:

newux newux

That is a good compromise for now, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants