New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last vote time in account object #1393

Closed
abitmore opened this Issue Oct 18, 2018 · 3 comments

Comments

@abitmore
Copy link
Member

abitmore commented Oct 18, 2018

User Story
As a UI developer I want a "last vote time" field available in account object so that UI can use it to fight voter apathy: bitshares/bitshares-ui#1934 (comment).

IMHO, the time should be updated when a user changed her votes but not every time when she updated her account.

Impacts
Describe which portion(s) of BitShares Core may be impacted by your request. Please tick at least one box.

  • API (the application programming interface)
  • Build (the build process or something prior to compiled code)
  • CLI (the command line wallet)
  • Deployment (the deployment process after building such as Docker, Travis, etc.)
  • DEX (the Decentralized EXchange, market engine, etc.)
  • P2P (the peer-to-peer network for transaction/block propagation)
  • Performance (system or user efficiency, etc.)
  • Protocol (the blockchain logic, consensus, validation, etc.)
  • Security (the security of system or user data, etc.)
  • UX (the User Experience)
  • Other (please add below)

Additional Context (optional)
Add any other context about your request here.

CORE TEAM TASK LIST

  • Evaluate / Prioritize Feature Request
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation

@abitmore abitmore added this to the Future Feature Release milestone Oct 18, 2018

@abitmore abitmore added this to New -Awaiting Core Team Evaluation in Project Backlog via automation Oct 18, 2018

@pmconrad pmconrad removed this from New -Awaiting Core Team Evaluation in Project Backlog Oct 19, 2018

@oxarbitrage oxarbitrage self-assigned this Oct 29, 2018

@ryanRfox ryanRfox added this to In Development in Community Claims Nov 1, 2018

@oxarbitrage

This comment has been minimized.

Copy link
Member

oxarbitrage commented Nov 12, 2018

I first started this as a change to be done in the account_evaluator.cpp. More specifically i added a new field last_vote_time to the stats and was updating the date at account_update_evaluator::verify_account_votes.

The problem with this is that date will not be updated if your proxy voted for you, so i am thinking now the changes haves to be done into db_maint.cpp at around https://github.com/bitshares/bitshares-core/blob/develop/libraries/chain/db_maint.cpp#L1120

Feedback is needed, thanks.

@pmconrad

This comment has been minimized.

Copy link
Contributor

pmconrad commented Nov 13, 2018

The problem with this is that date will not be updated if your proxy voted for you,

IMO the last_vote_time should be updated when either the user votes on his own (i. e. updates his votes), or when he updates his vote settings. If the UI wants to display the last vote change time of the users proxy, it can be looked up separately in the proxy's account stats.

@oxarbitrage

This comment has been minimized.

Copy link
Member

oxarbitrage commented Dec 16, 2018

closed by #1449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment