Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2P layer message padding data leak #1999

Closed
2 of 17 tasks
pmconrad opened this issue Sep 21, 2019 · 2 comments
Closed
2 of 17 tasks

P2P layer message padding data leak #1999

pmconrad opened this issue Sep 21, 2019 · 2 comments
Assignees
@pmconrad
Labels
3d Bug Classification indicating the existing implementation does not match the intention of the design 4c High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive 6 P2P Impact flag identifying the peer-to-peer (P2P) layer 6 Security Impact flag identifying system/user security 9a Tiny Effort estimation indicating TBD
Milestone
3.3.2 bugfix release

Comments

@pmconrad
Copy link
Contributor

Bug Description
The P2P layer pads message to a multiple of 16 bytes. This padding contains uninitialized bytes, which could contain security-relevant data.

Impacts
Describe which portion(s) of BitShares Core may be impacted by this bug. Please tick at least one box.

  • API (the application programming interface)
  • Build (the build process or something prior to compiled code)
  • CLI (the command line wallet)
  • Deployment (the deployment process after building such as Docker, Travis, etc.)
  • DEX (the Decentralized EXchange, market engine, etc.)
  • P2P (the peer-to-peer network for transaction/block propagation)
  • Performance (system or user efficiency, etc.)
  • Protocol (the blockchain logic, consensus, validation, etc.)
  • Security (the security of system or user data, etc.)
  • UX (the User Experience)
  • Other (please add below)

Expected Behavior
The padding bytes should be initialized properly. Any "standard" padding scheme that does not change the number of blocks is acceptable, e. g. simple zero-padding.

Additional Context (optional)
Thanks to @HarukaMa for noticing this.

CORE TEAM TASK LIST

  • Evaluate / Prioritize Bug Report
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@pmconrad pmconrad added 3d Bug Classification indicating the existing implementation does not match the intention of the design 4c High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive 6 P2P Impact flag identifying the peer-to-peer (P2P) layer 6 Security Impact flag identifying system/user security 9a Tiny Effort estimation indicating TBD labels Sep 21, 2019
@pmconrad pmconrad added this to the 4.1.0 - Feature Release milestone Sep 21, 2019
@pmconrad pmconrad added this to To do in Protocol Upgrade Release (5.0.0) via automation Sep 21, 2019
@pmconrad
Copy link
Contributor Author

steemit/steem@0bda58f

@pmconrad pmconrad self-assigned this Sep 22, 2019
@pmconrad pmconrad mentioned this issue Sep 22, 2019
Merged
@jmjatlanta jmjatlanta mentioned this issue Sep 23, 2019
Closed
@pmconrad
Copy link
Contributor Author

Fixed by #2002

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmconrad pmconrad

Labels
3d Bug Classification indicating the existing implementation does not match the intention of the design 4c High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive 6 P2P Impact flag identifying the peer-to-peer (P2P) layer 6 Security Impact flag identifying system/user security 9a Tiny Effort estimation indicating TBD
Projects
None yet
Milestone
3.3.2 bugfix release
Development

No branches or pull requests
1 participant
@pmconrad