Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match force-settlements with margin calls at normal margin call fill price #2481

Closed
2 of 17 tasks
abitmore opened this issue Jun 28, 2021 · 1 comment · Fixed by #2489
Closed
2 of 17 tasks

Match force-settlements with margin calls at normal margin call fill price #2481

abitmore opened this issue Jun 28, 2021 · 1 comment · Fixed by #2489

Comments

@abitmore
Copy link
Member

abitmore commented Jun 28, 2021

User Story

As a user I'd like that force-settlements are matched with margin calls with conditions:

  • no need to wait for the force-settlement delay when margin call appears
  • match price is in favor of force-settle orders, i.e. at current_feed_price.settlement_price / (MSSR-MCFR)
    • if filling at the match price above would trigger a black swan event, fill at 100% CR price instead; after filled, if there are remaining debt in the margin call, trigger black swan event normally
  • no force-settlement fee charged in this case
  • the volume is not counted in the force-settlement volume per maintenance interval
  • the matching takes place after processed limit (buy) orders with better price
  • sell orders whose price are lower than margin calls won't be matched with force-settlements, because force-settlement are meant to improve overall collateral ratio.

Impacts
Describe which portion(s) of BitShares Core may be impacted by your request. Please tick at least one box.

  • API (the application programming interface)
  • Build (the build process or something prior to compiled code)
  • CLI (the command line wallet)
  • Deployment (the deployment process after building such as Docker, Travis, etc.)
  • DEX (the Decentralized EXchange, market engine, etc.)
  • P2P (the peer-to-peer network for transaction/block propagation)
  • Performance (system or user efficiency, etc.)
  • Protocol (the blockchain logic, consensus, validation, etc.)
  • Security (the security of system or user data, etc.)
  • UX (the User Experience)
  • Other (please add below)

CORE TEAM TASK LIST

  • Evaluate / Prioritize Feature Request
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@abitmore
Copy link
Member Author

abitmore commented Aug 5, 2021

Done via #2489.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant