Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler warnings in macOS native build #2501

Closed
abitmore opened this issue Sep 17, 2021 · 1 comment
Closed

Compiler warnings in macOS native build #2501

abitmore opened this issue Sep 17, 2021 · 1 comment
Projects
Feature Release (6.1.0)
Milestone
6.1.0 - Feature R...

Comments

@abitmore
Copy link
Member

abitmore commented Sep 17, 2021 •
edited

macOS 10.15.7 (see https://github.com/bitshares/bitshares-core/runs/3627081567)

2021-09-16T23:53:35.9359200Z /Users/runner/work/bitshares-core/bitshares-core/libraries/fc/include/fc/static_variant.hpp:91:13: warning: destructor called on non-final 'graphene::protocol::transfer_operation' that has virtual functions but non-virtual destructor [-Wdelete-non-abstract-non-virtual-dtor]
2021-09-16T23:53:35.9361690Z reinterpret_cast<T*>(data)->~T();
2021-09-16T23:53:35.9362450Z ^

By the way, the same warnings appear in Linux cross-build too (see #2340).
@abitmore abitmore added this to the Future Feature Release milestone Sep 17, 2021
@abitmore abitmore added this to New -Awaiting Core Team Evaluation in Project Backlog via automation Sep 17, 2021
@abitmore abitmore removed this from New -Awaiting Core Team Evaluation in Project Backlog Sep 17, 2021
@abitmore abitmore added this to To do in Feature Release (6.1.0) via automation Sep 17, 2021
@abitmore abitmore mentioned this issue Dec 23, 2021
Merged
@abitmore abitmore moved this from To do to In progress in Feature Release (6.1.0) Dec 23, 2021
@abitmore abitmore mentioned this issue Dec 23, 2021
Open
@abitmore
Copy link
Member Author

abitmore commented Dec 24, 2021 •
edited

Fixed by #2566.

Feature Release (6.1.0) automation moved this from In progress to Done Dec 24, 2021
@abitmore abitmore mentioned this issue Nov 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Feature Release (6.1.0)
  
Done
Milestone
6.1.0 - Feature Release
Development

No branches or pull requests
1 participant
@abitmore