Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler warnings in macOS native build #2567

Open
abitmore opened this issue Dec 24, 2021 · 0 comments
Open

Compiler warnings in macOS native build #2567

abitmore opened this issue Dec 24, 2021 · 0 comments

Comments

@abitmore
Copy link
Member

abitmore commented Dec 24, 2021

Code version: develop branch (ac1cfc0)
OS: macOS 11 (see https://github.com/bitshares/bitshares-core/runs/4621251504)
Boost version: 1.69
OpenSSL version: 1.1.1

/Applications/Xcode_13.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: libfc.a(non_preemptable_scope_check.cpp.o) has no symbols
/Applications/Xcode_13.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: libfc.a(non_preemptable_scope_check.cpp.o) has no symbols

This was reported in #2340 too, should be fixed by #2660:

In file included from /Users/runner/work/bitshares-core/bitshares-core/libraries/chain/database.cpp:30:
/Users/runner/work/bitshares-core/bitshares-core/libraries/chain/db_maint.cpp:530:27: warning: lambda capture 'witness_budget' is not used [-Wunused-lambda-capture]
modify(core, [&rec,&witness_budget,&worker_budget,&leftover_worker_funds,&dpo]
~~^~~~~~~~~~~~~~
/Users/runner/work/bitshares-core/bitshares-core/libraries/chain/db_maint.cpp:530:43: warning: lambda capture 'worker_budget' is not used [-Wunused-lambda-capture]
modify(core, [&rec,&witness_budget,&worker_budget,&leftover_worker_funds,&dpo]
~~^~~~~~~~~~~~~
/Users/runner/work/bitshares-core/bitshares-core/libraries/chain/db_maint.cpp:530:58: warning: lambda capture 'leftover_worker_funds' is not used [-Wunused-lambda-capture]
modify(core, [&rec,&witness_budget,&worker_budget,&leftover_worker_funds,&dpo]
~~^~~~~~~~~~~~~~~~~~~~~
/Users/runner/work/bitshares-core/bitshares-core/libraries/chain/db_maint.cpp:530:81: warning: lambda capture 'dpo' is not used [-Wunused-lambda-capture]
modify(core, [&rec,&witness_budget,&worker_budget,&leftover_worker_funds,&dpo]
^

About boost random generator helper:

In file included from /Users/runner/work/bitshares-core/bitshares-core/tests/cli/main.cpp:63:
In file included from /Users/runner/work/bitshares-core/bitshares-core/tests/cli/../common/init_unit_test_suite.hpp:28:
In file included from /usr/local/opt/boost@1.69/include/boost/test/included/unit_test.hpp:22:
/usr/local/opt/boost@1.69/include/boost/test/impl/framework.ipp:763:30: warning: 'random_shuffle<std::__wrap_iter<unsigned long *>, const boost::unit_test::framework::state::random_generator_helper &>' is deprecated [-Wdeprecated-declarations]
std::random_shuffle( children_with_the_same_rank.begin(), children_with_the_same_rank.end(), rand_gen );
^
/Applications/Xcode_13.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.0.sdk/usr/include/c++/v1/algorithm:3158:1: note: 'random_shuffle<std::__wrap_iter<unsigned long *>, const boost::unit_test::framework::state::random_generator_helper &>' has been explicitly marked deprecated here
_LIBCPP_DEPRECATED_IN_CXX14 void
^
/Applications/Xcode_13.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.0.sdk/usr/include/c++/v1/__config:1069:39: note: expanded from macro '_LIBCPP_DEPRECATED_IN_CXX14'
# define _LIBCPP_DEPRECATED_IN_CXX14 _LIBCPP_DEPRECATED
^
/Applications/Xcode_13.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.0.sdk/usr/include/c++/v1/__config:1052:48: note: expanded from macro '_LIBCPP_DEPRECATED'
# define _LIBCPP_DEPRECATED __attribute__ ((deprecated))
^

It appears when building chain_test and app_test too.

@abitmore abitmore added this to the 6.1.0 - Feature Release milestone Dec 24, 2021
@abitmore abitmore added this to To do in Feature Release (6.1.0) via automation Dec 24, 2021
@abitmore abitmore removed this from To do in Feature Release (6.1.0) Oct 23, 2022
@abitmore abitmore added this to To do in Feature Release (7.1.0) via automation Oct 23, 2022
@abitmore abitmore added this to To do in Feature Release (6.1.0) via automation Oct 23, 2022
@abitmore abitmore moved this from To do to In progress in Feature Release (6.1.0) Oct 23, 2022
@abitmore abitmore moved this from In progress to Done in Feature Release (6.1.0) Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant